NDIS: Harden QoS bytes calculation in netvmini control path#1386
Merged
5an7y-Microsoft merged 2 commits intoMay 21, 2026
Conversation
- Replaced direct size arithmetic in NICSetQOSParameters with checked integer-safe operations. - Added overflow handling for classification table size computation: - Multiply NumClassificationElements × ClassificationElementSize via RtlULongMult. - Add the revision header size via RtlULongAdd. - Return NDIS_STATUS_INVALID_LENGTH when either checked operation fails, instead of relying on unchecked arithmetic.
amrutha-chandramohan
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes:
CodeQL Scanning Alert in network/ndis/netvmini/6x/ctrlpath.c - Multiplication result converted to larger type
Summary: